Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add script examples to browser checks #939

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

VikaCep
Copy link
Contributor

@VikaCep VikaCep commented Sep 19, 2024

Adds script examples to browser checks, taken from https://github.com/grafana/xk6-browser/tree/main/examples

image

Some of them were omitted as they include features we don't support yet, such as page screenshots.

@VikaCep VikaCep self-assigned this Sep 19, 2024
@VikaCep VikaCep requested a review from a team as a code owner September 19, 2024 15:31
@VikaCep VikaCep requested a review from ckbedwell September 19, 2024 15:31
Copy link
Contributor

@ckbedwell ckbedwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🔥🔥🔥

@VikaCep VikaCep merged commit 72c4a76 into main Sep 19, 2024
5 checks passed
@VikaCep VikaCep deleted the browser-checks-examples branch September 19, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants