Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pprof flag to optionally expose pprof data #590

Merged
merged 1 commit into from
Sep 5, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .chloggen/pprof.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement

# The name of the component, or a single word describing the area of concern, (e.g. operator, github action)
component: operator

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Add pprof flag to optionally expose pprof data

# One or more tracking issues related to the change
issues: [242]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext:
6 changes: 5 additions & 1 deletion cmd/start/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ func start(c *cobra.Command, args []string) {
setupLog := ctrl.Log.WithName("setup")
version := version.Get()

options.PprofBindAddress, _ = c.Flags().GetString("pprof-addr")

mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), options)
if err != nil {
setupLog.Error(err, "unable to start manager")
Expand Down Expand Up @@ -136,9 +138,11 @@ func addDependencies(mgr ctrl.Manager, ctrlConfig configv1alpha1.ProjectConfig,

// NewStartCommand returns a new start command.
func NewStartCommand() *cobra.Command {
return &cobra.Command{
cmd := &cobra.Command{
Use: "start",
Short: "Start the Tempo operator",
Run: start,
}
cmd.Flags().String("pprof-addr", "", "The address the pprof server binds to. Default is empty string which disables the pprof server.")
return cmd
}
Loading