Handle ingester panic with corrupt buffers (#600)

Signed-off-by: Joe Elliott <number101010@gmail.com>
grafana · Mar 17, 2021 · 59d3f97 · 59d3f97
1 parent f7093f5
commit 59d3f97
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/tempodb/encoding/base/object.go b/tempodb/encoding/base/object.go
@@ -66,6 +66,9 @@ func UnmarshalObjectFromReader(r io.Reader) (common.ID, []byte, error) {
 	if uint32(readLength) != protoLength {
 		return nil, nil, fmt.Errorf("read %d but expected %d", readLength, protoLength)
 	}
+	if int(idLength) > len(b) {
+		return nil, nil, fmt.Errorf("id length %d outside bounds of buffer %d. corrupt buffer?", idLength, len(b))
+	}
 
 	bytesID := b[:idLength]
 	bytesObject := b[idLength:]