Skip to content

Commit

Permalink
Make overrides configmap block name consistent (#906)
Browse files Browse the repository at this point in the history
* Make overrides configmap block name consistent

* Change its references

* Changelog entry
  • Loading branch information
kavirajk authored Aug 24, 2021
1 parent 6cba13f commit aed734c
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 4 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
* [ENHANCEMENT] Added "query blocks" cli option. [#876](https://github.com/grafana/tempo/pull/876) (@joe-elliott)
* [ENHANCEMENT] Added traceid to `trace too large message`. [#888](https://github.com/grafana/tempo/pull/888) (@mritunjaysharma394)
* [ENHANCEMENT] Add support to tempo workloads to `overrides` from single configmap in microservice mode. [#896](https://github.com/grafana/tempo/pull/896) (@kavirajk)
* [ENHANCEMENT] Make `overrides_config` block name consistent with Loki and Cortex in microservice mode. [#906](https://github.com/grafana/tempo/pull/906) (@kavirajk)

## v1.1.0-rc.0 / 2021-08-11

Expand Down
2 changes: 1 addition & 1 deletion operations/jsonnet/microservices/compactor.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
}) +
deployment.mixin.spec.template.spec.withVolumes([
volume.fromConfigMap(tempo_config_volume, $.tempo_compactor_configmap.metadata.name),
volume.fromConfigMap(tempo_overrides_config_volume, $.overrides_configmap.metadata.name),
volume.fromConfigMap(tempo_overrides_config_volume, $.overrides_config.metadata.name),
]),

tempo_compactor_service:
Expand Down
2 changes: 1 addition & 1 deletion operations/jsonnet/microservices/configmap.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
tempo_query_frontend_config:: $.tempo_config{},

// This will be the single configmap that stores `overrides.yaml`.
overrides_configmap:
overrides_config:
configMap.new($._config.overrides_configmap_name) +
configMap.withData({
'overrides.yaml': k.util.manifestYaml({
Expand Down
2 changes: 1 addition & 1 deletion operations/jsonnet/microservices/distributor.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
}) +
deployment.mixin.spec.template.spec.withVolumes([
volume.fromConfigMap(tempo_config_volume, $.tempo_distributor_configmap.metadata.name),
volume.fromConfigMap(tempo_overrides_config_volume, $.overrides_configmap.metadata.name),
volume.fromConfigMap(tempo_overrides_config_volume, $.overrides_config.metadata.name),
]),

tempo_distributor_service:
Expand Down
2 changes: 1 addition & 1 deletion operations/jsonnet/microservices/ingester.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
})
+ statefulset.mixin.spec.template.spec.withVolumes([
volume.fromConfigMap(tempo_config_volume, $.tempo_ingester_configmap.metadata.name),
volume.fromConfigMap(tempo_overrides_config_volume, $.overrides_configmap.metadata.name),
volume.fromConfigMap(tempo_overrides_config_volume, $.overrides_config.metadata.name),
]),

tempo_ingester_service:
Expand Down

0 comments on commit aed734c

Please sign in to comment.