Skip to content

Commit

Permalink
Remove panic in ReportFatalError (#343)
Browse files Browse the repository at this point in the history
* Remove panic

Signed-off-by: Joe Elliott <number101010@gmail.com>

* changelog

Signed-off-by: Joe Elliott <number101010@gmail.com>
  • Loading branch information
joe-elliott committed Nov 17, 2020
1 parent 1e492cb commit fca9484
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 1 deletion.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
* [CHANGE] Upgrade Cortex from v1.3.0 to v.1.4.0 [#341](https://github.com/grafana/tempo/pull/341)
* [ENHANCEMENT] Add tempodb_compaction_objects_combined metric. [#339](https://github.com/grafana/tempo/pull/339)
* [BUGFIX] Frequent errors logged by compactor regarding meta not found [#327](https://github.com/grafana/tempo/pull/327)
* [BUGFIX] Fix distributors panicking on rollout [#343](https://github.com/grafana/tempo/pull/343)

## v0.3.0

Expand Down
1 change: 0 additions & 1 deletion modules/distributor/receiver/shim.go
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,6 @@ func (r *receiversShim) ConsumeTraces(ctx context.Context, td pdata.Traces) erro
// implements component.Host
func (r *receiversShim) ReportFatalError(err error) {
level.Error(util.Logger).Log("msg", "fatal error reported", "err", err)
panic(fmt.Sprintf("Fatal error %v", err))
}

// implements component.Host
Expand Down

0 comments on commit fca9484

Please sign in to comment.