Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase complete block timeout #421

Merged
merged 3 commits into from
Dec 18, 2020

Conversation

joe-elliott
Copy link
Member

What this PR does:
Increases the complete block timeout default to be 1 minute greater than the default poll cycle. This will prevent race conditions where a complete block is removed from an ingester but the querier has not yet repolled the backend blocks.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

…en querying traces that have been flushed

Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
@annanay25
Copy link
Contributor

I'm a little confused how this will help... The queriers and blocklist will have an offset in terms of polling anyway right?

@joe-elliott
Copy link
Member Author

joe-elliott commented Dec 17, 2020

The current defaults just have a small chance of race condition. It seemed simple enough to correct.

Also, in the single binary they would be synced up for at least the first few iterations.

@annanay25 annanay25 merged commit 65a0643 into grafana:master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants