Increase complete block timeout #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en querying traces that have been flushed Signed-off-by: Joe Elliott <number101010@gmail.com>
|
I'm a little confused how this will help... The queriers and blocklist will have an offset in terms of polling anyway right? |
|
The current defaults just have a small chance of race condition. It seemed simple enough to correct. Also, in the single binary they would be synced up for at least the first few iterations. |
annanay25
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Increases the complete block timeout default to be 1 minute greater than the default poll cycle. This will prevent race conditions where a complete block is removed from an ingester but the querier has not yet repolled the backend blocks.
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]