Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Update Helm chart doc #4326

Closed
8 tasks done
knylander-grafana opened this issue Nov 14, 2024 · 5 comments · Fixed by #4370
Closed
8 tasks done

[DOC] Update Helm chart doc #4326

knylander-grafana opened this issue Nov 14, 2024 · 5 comments · Fixed by #4370
Assignees
Labels
type/docs Improvements or additions to documentation

Comments

@knylander-grafana
Copy link
Contributor

knylander-grafana commented Nov 14, 2024

Update the Helm chart documentation to address gaps in content and common questions.

Helm chart doc: #4326

pages to update:

Related:

Tasks

Preview Give feedback
  1. keepalive type/docs
@knylander-grafana knylander-grafana added the type/docs Improvements or additions to documentation label Nov 14, 2024
@knylander-grafana knylander-grafana changed the title Update Helm chart doc [DOC] Update Helm chart doc Nov 14, 2024
@knylander-grafana
Copy link
Contributor Author

Zach's PR to handle TLS with Helm - #4328

@hedss
Copy link
Contributor

hedss commented Nov 18, 2024

Just rough C&P from GET install today:

  • 4 cores and 16GB memory (don't believe this, unless it's 4vCPU per core, and anti-affinitising components could actually fail here if there aren't enough nodes)
  • Image tag shouldn't be set because for latest chart version options will be wrong, latest is always defined as App Version anyway)
  • Don't need to enable enterpriseGateway if enterprise is enabled, not even sure this flag is still valid?
  • Don't need to explicitly disable gateway (it's never on by default) anyway
  • Minio isn't enabled by default so you don't need to disable it in the chart if not using it
  • Add an example of both Tempo and GET gateways for ingress (it's not clear how these are different and has caused confusion). We should be very clear on what each does and how to configure it. I don't think we should be explicitly stating the Enterprise Gateway by default as this could add an ingress when only an internal cluster/shared VPC setup is required.

Worth checking the rest of the doc too for other things when we go through this.
cc @ayah-el @danstadler-pdx

@knylander-grafana
Copy link
Contributor Author

knylander-grafana commented Nov 20, 2024

Verify that the GRPC endpoint for streaming is listed. Http2 proxy.
Related: #3987 (comment)

From Joe:
I have not operated istio so I can't say for sure. You will need to make sure that envoy is proxying HTTP2 generically or perhaps it supports GRPC more specifically?

Yes it seems there is missing config in the nginx gw in the helm chart to allow for TraceQL streaming. I'm was looking at the config here and I don't see a pass for the streaming GRPC endpoint. It may also need special config for proxying HTTP2.

@knylander-grafana knylander-grafana moved this from Todo to In Progress in Tempo squad Nov 20, 2024
@knylander-grafana
Copy link
Contributor Author

PR to address FE issue:#4370

@knylander-grafana
Copy link
Contributor Author

Overrides doc updated in this PR: #4415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants