-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overrides configmap to querier, update docs for new limit #1153
Conversation
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
…he-limits Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
@KMiller-Grafana Thanks for the review. I'm going to merge this one as I have addressed your comments. There were no other docs changes. Edit: Oh I can't merge until you approve. I'll wait :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs look good to me now. Thanks for the changes.
Signed-off-by: Annanay annanayagarwal@gmail.com
What this PR does:
Before:
After
Ok, the machine used in second run might have been better but still reductions in
TestMicroservices
andTestScalableSingleBinary
.Which issue(s) this PR fixes:
Follow up from #1068
Marking draft because this is 100% going to collide with #1129Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]