Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Blocklist backend metrics #1519

Merged
merged 3 commits into from
Jun 30, 2022
Merged

Adding Blocklist backend metrics #1519

merged 3 commits into from
Jun 30, 2022

Conversation

ie-pham
Copy link
Contributor

@ie-pham ie-pham commented Jun 28, 2022

What this PR does:
This adds additional blocklist backend metrics as mentioned in #1502 which are total backend objects and total backend bytes.

Which issue(s) this PR fixes:
Fixes #1502

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@CLAassistant
Copy link

CLAassistant commented Jun 28, 2022

CLA assistant check
All committers have signed the CLA.

@ie-pham ie-pham marked this pull request as ready for review June 28, 2022 20:35
Copy link
Contributor

@annanay25 annanay25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @ie-pham! Happy to see your PR 🚀

CHANGELOG.md Outdated Show resolved Hide resolved
tempodb/blocklist/poller_test.go Outdated Show resolved Hide resolved
tempodb/blocklist/poller.go Outdated Show resolved Hide resolved
tempodb/blocklist/poller.go Outdated Show resolved Hide resolved
tempodb/blocklist/poller.go Outdated Show resolved Hide resolved
@ie-pham ie-pham requested review from annanay25 and joe-elliott June 30, 2022 18:51
@ie-pham ie-pham requested a review from joe-elliott June 30, 2022 19:51
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's go!

@joe-elliott joe-elliott merged commit ff9f798 into grafana:main Jun 30, 2022
joe-elliott pushed a commit to joe-elliott/tempo that referenced this pull request Jul 7, 2022
* Adding Blocklist backend metrics

* refactoring function to return struct

* changing total bytes variables back to uint64

Co-authored-by: Jennie Pham <jenniepham@Jennies-MBP.attlocal.net>
@ie-pham ie-pham deleted the jennie/1502 branch March 17, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more blocklist metrics
4 participants