Add several metrics-generator fields to user-configurable overrides #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yvrhdn
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
…imple-fields # Conflicts: # CHANGELOG.md # modules/overrides/limits.go
domasx2
reviewed
Jul 27, 2023
mdisibio
reviewed
Jul 28, 2023
mdisibio
approved these changes
Jul 28, 2023
yvrhdn
deleted the
kvrhdn/user-configurable-metrics-generator-simple-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Extends the user-configurable overrides added in #2543 with several metrics_generator_... overrides.
I adopted the nested structure proposed in #2688
New JSON payload:
{ "forwarders": [], "metrics_generator": { "disable_collection": true, "processors": ["service-graphs"], "processor": { "span_metrics": { "dimensions": ["env"], "enable_target_info": true }, "service_graphs": { "dimensions": ["env"], "enable_client_server_prefix": true, "peer_attributes": ["att"] } } } }Which issue(s) this PR fixes:
Fixes #Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]