Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tempo-mixin] Increase notification delay for TempoTenantIndexTooOld #3115

Closed
wants to merge 1 commit into from
Closed

[tempo-mixin] Increase notification delay for TempoTenantIndexTooOld #3115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion operations/tempo-mixin-compiled/alerts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
"runbook_url": "https://github.com/grafana/tempo/tree/main/operations/tempo-mixin/runbook.md#TempoTenantIndexTooOld"
"expr": |
max by (cluster, namespace, tenant) (tempodb_blocklist_tenant_index_age_seconds{}) > 600
"for": "5m"
"for": "20m"
"labels":
"severity": "critical"
- "alert": "TempoBlockListRisingQuickly"
Expand Down
2 changes: 1 addition & 1 deletion operations/tempo-mixin/alerts.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@
expr: |||
max by (%s) (tempodb_blocklist_tenant_index_age_seconds{}) > %s
||| % [$._config.group_by_tenant, $._config.alerts.max_tenant_index_age_seconds],
'for': '5m',
'for': '20m',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe 700s is more reasonable.

Copy link
Member

@electron0zero electron0zero Nov 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: why 700s? also why 20m?

I was assuming that tempo operators can use max_tenant_index_age_seconds to tune this alert? and don't have to bump for?.

I am not aginst the chage, just want to know the reason for the change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good questions. The PR is because I've been noticing that this flaps quite a bit, causing alert noise when no action is required to being it back into desired state. Perhaps there is another approach we can take here, or tweak to be slightly more targeted. What do you think?

Copy link
Contributor Author

@zalegrala zalegrala Nov 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh 20m because I was just rusing up a PR after getting paged. The 700s is 2x the polling cycle (600s) plus 100s for good measure in case we're on a boundary. But this is based on default values.

labels: {
severity: 'critical',
},
Expand Down