#306 - Compactor flush to backend based on buffer size #325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Changes the compactor to flush partial blocks to the backend based on buffered data size instead of trace count. The default is 30MB. This ensures that at least 5MB of data can be buffered for the S3 parts, and should work well without tuning across most cases, no matter if traces are large or small. Exposed as configuration option flush_size_bytes. The default value allows for a maximum block size of 300GB (10,000 parts maximum).
Which issue(s) this PR fixes:
Fixes #306
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]