Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TraceQL] Add support for querying link attributes #3814

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

ie-pham
Copy link
Contributor

@ie-pham ie-pham commented Jun 26, 2024

What this PR does: Add support for querying link attributes. This can only be merged after #3748

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Screenshot 2024-06-28 at 4 58 19 PM

@@ -128,6 +128,16 @@ Find any database connection string that goes to a Postgres or MySQL database:
{ span.db.system =~ "postgresql|mysql" }
```

You can query for an exception in your span event
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can query for an exception in your span event
You can query for an exception in your span event:

{ event.exception.message =~ "something went wrong" }
```

You can search for an attribute in your link
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can search for an attribute in your link
You can search for an attribute in your link:

Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the docs!

Approving the docs only.

@ie-pham
Copy link
Contributor Author

ie-pham commented Jun 30, 2024

Searching for both link and event attributes at the same time working as expected
Screenshot 2024-06-30 at 11 53 10 AM

Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Killing it, pham

Copy link
Contributor

@knylander-grafana knylander-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the docs. Doc updates look good.

@ie-pham ie-pham merged commit 6388aa6 into grafana:main Jul 1, 2024
15 checks passed
@knylander-grafana knylander-grafana added the type/docs Improvements or additions to documentation label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants