fix: remove unused properties from the WAL config file #3911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiermolinar
requested review from
knylander-grafana,
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
joe-elliott
reviewed
Jul 25, 2024
CHANGELOG.md
Outdated
| @@ -50,7 +50,7 @@ | |||
| * [BUGFIX] Improved handling of complete blocks in localblocks processor after enabling flusing [#3805](https://github.com/grafana/tempo/pull/3805) (@mapno) | |||
| * [BUGFIX] Handle out of boundaries spans kinds [#3861](https://github.com/grafana/tempo/pull/3861) (@javiermolinar) | |||
| * [BUGFIX] Maintain previous tenant blocklist on tenant errors [#3860](https://github.com/grafana/tempo/pull/3860) (@zalegrala) | |||
|
|
|||
| * [BUGFIX] Remove unused properties from the WAL configuration [#3911](https://github.com/grafana/tempo/pull/3911) (@javiermolianr) | |||
There was a problem hiding this comment.
we need to list this as a breaking change. we do that by typing **Breaking Change** on the changelog line like this:
Line 3 in d0f0a5f
that will help us find and note the removal of these config optoins for our users when we cut 2.6
There was a problem hiding this comment.
Done, I didn't think this was a breaking change because the configuration was not honored ever :P
There was a problem hiding this comment.
That is a good point, but we are removing config options that previously were parsed. It might break someone's config I suppose.
| @@ -597,8 +595,6 @@ storage: | |||
| queue_depth: 20000 | |||
| wal: | |||
| path: /var/tempo/wal | |||
| completedfilepath: /var/tempo/wal/completed | |||
There was a problem hiding this comment.
nice. i'm impressed you found and updated the manifest :)
joe-elliott
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
It removes the properties
completedfilepathandblocksfilepathfrom the configuration of the WAL. The former one is not needed anymore and setting the latter one is a bit pointless since it can be just hanging fromfile pathWhich issue(s) this PR fixes:
Fixes #3902
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]