Javi Maintainer #4171
Merged
Javi Maintainer #4171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
annanay25,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
yvrhdn
approved these changes
Oct 10, 2024
mdisibio
approved these changes
Oct 10, 2024
knylander-grafana
approved these changes
Oct 11, 2024
mapno
approved these changes
Oct 11, 2024
ie-pham
approved these changes
Oct 11, 2024
|
o7 |
knylander-grafana
pushed a commit
to knylander-grafana/tempo-doc-work
that referenced
this pull request
Oct 11, 2024
Signed-off-by: Joe Elliott <number101010@gmail.com>
This was referenced Nov 28, 2024
Merged
electron0zero
added a commit
that referenced
this pull request
Nov 28, 2024
we missed adding @javiermolinar in /docs/ and /.github overrides, in #4171. This means that if a PR contains changes in /docs or /.github, @javiermolinar's review is not counted as a valid review, this PR fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Proposal to make @javiermolinar a maintainer. An approving review is a vote in favor.
Tempo Updates
Tempo Reviews
@grafana/tempo