Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude auth for internal grpc calls b/n worker and frontend #435

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

annanay25
Copy link
Contributor

Signed-off-by: Annanay annanayagarwal@gmail.com

What this PR does:
Follow up of #400. Skips authentication for internal grpc call /frontend.Frontend/Process used between the query worker and frontend, as this is a common call used for all users.

Which issue(s) this PR fixes:
Fixes #NA

Checklist

  • NA Tests updated
  • NA Documentation added
  • NA CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Annanay <annanayagarwal@gmail.com>
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected map[string]struct{} and checking for existence to be faster, but benchmarks show that your way is.

Approved!

@joe-elliott joe-elliott merged commit 582047b into grafana:master Jan 4, 2021
@annanay25 annanay25 deleted the fix-frontend-auth branch January 5, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants