-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade cortex to 1.6 and other dependencies. #442
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looking good, left a few comments.
…lve conflict between cortex 1.6 and otel collect 0.6.1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Left a final few comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
What this PR does:
This PR upgrades cortex to 1.6 in order to bring in an important fix: cortexproject/cortex#3603 There is a conflict between cortex v1.6.0 and open-telemetry-collector v0.6.1 on the prometheus/prometheus reference. It was addressed by committing a local copy of prometheus/prometheus/discovery/config module in the vendor-fix folder and replace directive was added to go.mod. This fix can be removed when the open-telemetry collector reference is updated.
Which issue(s) this PR fixes:
n/a
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]