[TraceQL] Improve performance of select() queries #4438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdisibio
requested review from
joe-elliott,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham,
stoewer and
javiermolinar
as code owners
joe-elliott
reviewed
Dec 11, 2024
|
Bumped to -count=10 and benchmarks show less variance and now after is faster, so good indicator it is noise. Nothing changed with the fetch or engine for anything except select. Benchmarks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This fixes the internal processing of some traceql queries to support more cases where AllConditions should be true- notably
select()queries. This means we can push all of the filtering down to storage more efficiently. The code change is to remove the check at the top when any multiple pipeline stages exist, and instead push let the individual elements decide. There are some remaining queries that maybe should also be AllConditions like{ } | avg(duration) > 1s, but they are left unchanged until they can be reviewed more thoroughly.Benchmark:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]