Standardize ingestion burst setting #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR renames IngestionMaxBatchSize to IngestionBurstSize to bring it more in line with cortex and loki. Instead of a max request size, it is more general purpose and in all cases the value is configured quite higher than the ingestion_rate_limit.
Some links:
https://github.com/grafana/loki/blob/master/pkg/util/validation/limits.go#L64 (default is 1.5x of rate)
https://github.com/cortexproject/cortex/blob/master/pkg/util/validation/limits.go#L97 (default 2x of rate)
Internally, the burst size is even more generous (generally 10x of rate).
It doesn't appear that we have documented the override/limit settings. There is good documentation in cortex here, that we should consider adopting: https://github.com/cortexproject/cortex/blob/master/docs/configuration/arguments.md#ingester-distributor--querier-limits
Which issue(s) this PR fixes:
n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]