Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to cut an active block based on total bytes #477

Merged
merged 8 commits into from
Jan 28, 2021

Conversation

mdisibio
Copy link
Contributor

@mdisibio mdisibio commented Jan 26, 2021

What this PR does:
Adds config value and logic to cut ingester headblock based on size. Default is 1GB.

Which issue(s) this PR fixes:
Fixes #474

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Copy link
Contributor

@achatterjee-grafana achatterjee-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one suggestion. Otherwise LGTM

docs/tempo/website/configuration/_index.md Outdated Show resolved Hide resolved
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This will make Tempo much easier to operate.

Have a couple of small questions, but other than that looks good.

integration/e2e/config-all-in-one.yaml Show resolved Hide resolved
tempodb/encoding/common/types.go Show resolved Hide resolved
@mdisibio mdisibio changed the title WIP: Add support to cut an active block based on total bytes Add support to cut an active block based on total bytes Jan 27, 2021
@joe-elliott joe-elliott merged commit d7bc9b1 into grafana:master Jan 28, 2021
@mdisibio mdisibio deleted the 474-ingester-max-block-bytes branch February 3, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to cut an active block based on total bytes
3 participants