-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to cut an active block based on total bytes #477
Add support to cut an active block based on total bytes #477
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one suggestion. Otherwise LGTM
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. This will make Tempo much easier to operate.
Have a couple of small questions, but other than that looks good.
What this PR does:
Adds config value and logic to cut ingester headblock based on size. Default is 1GB.
Which issue(s) this PR fixes:
Fixes #474
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]