-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update protobuf image version #502
Conversation
08b6d78
to
9cfbde8
Compare
Hi, thanks for looking into this. We have looked into upgrading the open-telemetry-collector dependency as well and it looks like this is running into the same hurdles.
The root cause is that a cmux test relies on grpc/examples, which conflicts with the grpc version required by cortex/etc. One possible way to address this is to vendor cmux and delete the conflicting test. Were you able to build and run this change locally? If so, I would be interested to learn how that worked, since we ran into the same hurdles. |
9cfbde8
to
dc15792
Compare
982d3b7
to
0fae2d8
Compare
69081b1
to
67958a6
Compare
67958a6
to
ffd9688
Compare
ffd9688
to
20e1ef6
Compare
We have talked and @mdisibio is pursuing a more holistic method of fix this. It will be a combination of fixing our vendor mangling, upgrade us to 1.16 and add direct support for OTEL proto into the distributors instead of relying on the shims. Thank you for the research @swartz-k, but I think it's best to let him carry this one forward. |
You are welcome. Thanks. |
What this PR does:
Update protobuf image and opentelemetry collector version
Which issue(s) this PR fixes:
Fixes #479
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]