Configurable http api prefix #631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
joe-elliott
requested review from
achatterjee-grafana,
annanay25,
dgzlopes and
mdisibio
as code owners
Signed-off-by: Joe Elliott <number101010@gmail.com>
annanay25
reviewed
Apr 6, 2021
mdisibio
approved these changes
Apr 6, 2021
Signed-off-by: Joe Elliott <number101010@gmail.com>
|
@annanay25 mixin fixed. are there places in the deployment jsonnet that need updating? |
|
Nope, I think this is all. |
annanay25
reviewed
Apr 6, 2021
| @@ -12,6 +12,7 @@ | |||
| This is a **breaking change** and will likely result in query errors on rollout as the query signature b/n QueryFrontend & Querier has changed. [#557](https://github.com/grafana/tempo/pull/557) | |||
| * [ENHANCEMENT] Add list compaction-summary command to tempo-cli [#588](https://github.com/grafana/tempo/pull/588) | |||
| * [ENHANCEMENT] Add list and view index commands to tempo-cli [#611](https://github.com/grafana/tempo/pull/611) | |||
| * [ENHANCEMENT] Add a configurable prefix for HTTP endpoints. [#631](https://github.com/grafana/tempo/pull/631) | |||
There was a problem hiding this comment.
Does this count as a breaking change?
There was a problem hiding this comment.
Unsure. It technically unbreaks the hardcoded /tempo breaking change :). So 0.6.0 => 0.7.0 will not be a breaking change. While this exact commit is a breaking change from the previous one.
I think for this reason we leave it out.
annanay25
approved these changes
Apr 6, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
/apiinstead of/tempo/apiChecklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]