Preallocate byte slices from prom pool #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Annanay <annanayagarwal@gmail.com>
joe-elliott
reviewed
Apr 28, 2021
joe-elliott
reviewed
Apr 28, 2021
joe-elliott
approved these changes
Apr 29, 2021
There was a problem hiding this comment.
I think this is ready to go. Going to approve so you can merge as convenient. Two things to look at before merging
- Double check whether
[:0]is necessary. Perhaps @mapno our resident slice expert can help :) - Add some tests as discussed.
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Signed-off-by: Annanay <annanayagarwal@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Annanay annanayagarwal@gmail.com
What this PR does:
Uses a custom protobuf type
PreallocRequestwhich reuses byte slices from a pool.The pool implementation is taken from prometheus.
Byte slices are "donated" back to the pool in the
func (i *Ingester) PushBytesfunction once the request is used.Which issue(s) this PR fixes:
Fixes #na!
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]