Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Query Frontend grpc settings to avoid noisy error log #690

Merged
merged 3 commits into from
May 11, 2021
Merged

Fix Query Frontend grpc settings to avoid noisy error log #690

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7d05f3
Fix Query Frontend grpc settings to avoid noisy error log
annanay25 May 10, 2021
2d11da2
Add comment above custom settings
annanay25 May 10, 2021
e830f48
Merge branch 'main' into frontend-grpc-settings
annanay25 May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
* [ENHANCEMENT] Add config option to disable write extension to the ingesters. [#677](https://github.com/grafana/tempo/pull/677)
* [ENHANCEMENT] Preallocate byte slices on ingester request unmarshal. [#679](https://github.com/grafana/tempo/pull/679)
* [ENHANCEMENT] Zipkin Support - CombineTraces. [#688](https://github.com/grafana/tempo/pull/688)
* [CHANGE] Fix Query Frontend grpc settings to avoid noisy error log. [#690](https://github.com/grafana/tempo/pull/690)

## v0.7.0

Expand Down
8 changes: 8 additions & 0 deletions cmd/tempo/app/app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import (
"flag"
"fmt"
"net/http"
"time"

cortex_frontend "github.com/cortexproject/cortex/pkg/frontend/v1"
"github.com/cortexproject/cortex/pkg/ring"
Expand Down Expand Up @@ -70,6 +71,13 @@ func (c *Config) RegisterFlagsAndApplyDefaults(prefix string, f *flag.FlagSet) {
// Server settings
flagext.DefaultValues(&c.Server)
c.Server.LogLevel.RegisterFlags(f)

// The following GRPC server settings are added to address this issue - https://github.com/grafana/tempo/issues/493
// The settings prevent the grpc server from sending a GOAWAY message if a client sends heartbeat messages
// too frequently (due to lack of real traffic).
c.Server.GRPCServerMinTimeBetweenPings = 10 * time.Second
annanay25 marked this conversation as resolved.
Show resolved Hide resolved
c.Server.GRPCServerPingWithoutStreamAllowed = true

f.IntVar(&c.Server.HTTPListenPort, "server.http-listen-port", 80, "HTTP server listen port.")
f.IntVar(&c.Server.GRPCListenPort, "server.grpc-listen-port", 9095, "gRPC server listen port.")

Expand Down
4 changes: 4 additions & 0 deletions operations/kube-manifests/Namespace-tracing.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
apiVersion: v1
annanay25 marked this conversation as resolved.
Show resolved Hide resolved
kind: Namespace
metadata:
name: tracing