Add histogram for flush size in bytes #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the observability of the ingester write path.
bboreham
requested review from
annanay25,
dgzlopes,
joe-elliott,
mapno and
mdisibio
as code owners
joe-elliott
reviewed
Jun 21, 2021
| @@ -275,6 +281,7 @@ func (i *Ingester) handleFlush(userID string, blockID uuid.UUID) (retry bool, er | |||
| start := time.Now() | |||
| err = i.store.WriteBlock(ctx, block) | |||
| metricFlushDuration.Observe(time.Since(start).Seconds()) | |||
| metricFlushSize.Observe(float64(block.BlockMeta().Size)) | |||
There was a problem hiding this comment.
this is fine, but keep in mind that this is the trace data only. it does not take into account the bloom filters, meta or index.
these other objects are small in comparison, but non-zero.
joe-elliott
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Add a histogram for size paralleling
tempo_ingester_flush_duration_seconds.This improves the observability of the ingester write path.
Checklist
CHANGELOG.mdupdated