Add flag for environment vars substitution in config file #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashmita152
requested review from
achatterjee-grafana,
annanay25,
dgzlopes,
joe-elliott,
mapno and
mdisibio
as code owners
|
|
annanay25
reviewed
Jun 25, 2021
There was a problem hiding this comment.
Thanks for working on this one @Ashmita152! 🚀 I've left a few comments.
Setting default value to false to keep backward compatibility Signed-off-by: Ashmita Bohara <ashmita.bohara152@gmail.com>
Ashmita152
force-pushed
the
expand-envvars
branch
from
f8ca23d
to
88199d8
Compare
annanay25
approved these changes
Jun 25, 2021
mapno
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting default value to false to keep backward compatibility
Signed-off-by: Ashmita Bohara ashmita.bohara152@gmail.com
What this PR does:
Which issue(s) this PR fixes:
Fixes #788
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]