Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Agent docs for lb #830

Merged
merged 4 commits into from
Aug 5, 2021

Conversation

mapno
Copy link
Member

@mapno mapno commented Jul 22, 2021

What this PR does:

Updates docs to reflect changes in grafana/agent#765

@@ -49,8 +49,8 @@ tempo:
policies:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • have we revendored otel to add additional features? can we add examples of tail based configs that use the additional features?
  • Can we include some details about how you only need the load balancing if you have more than one collector?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have we revendored otel to add additional features? can we add examples of tail based configs that use the additional features?

Yes, it's on v0.30 now. Added examples for the two new policies.

Can we include some details about how you only need the load balancing if you have more than one collector?

I think it's explained in the description, is anything missing in particular?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include some details about how you only need the load balancing if you have more than one collector?

Maybe we should make a separate section for load balancing? This will make it easier to distinguish between how tail sampling itself works and how you get it working with multiple agent instances.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe? I don't have a strong opinion about it, so I'm fine with whatever the team thinks is better in this case.

docs/tempo/website/grafana-agent/tail-based-sampling.md Outdated Show resolved Hide resolved
docs/tempo/website/grafana-agent/tail-based-sampling.md Outdated Show resolved Hide resolved
docs/tempo/website/grafana-agent/tail-based-sampling.md Outdated Show resolved Hide resolved
docs/tempo/website/grafana-agent/tail-based-sampling.md Outdated Show resolved Hide resolved
docs/tempo/website/grafana-agent/tail-based-sampling.md Outdated Show resolved Hide resolved
@@ -49,8 +49,8 @@ tempo:
policies:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include some details about how you only need the load balancing if you have more than one collector?

Maybe we should make a separate section for load balancing? This will make it easier to distinguish between how tail sampling itself works and how you get it working with multiple agent instances.

Copy link
Contributor

@achatterjee-grafana achatterjee-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor copy edit suggestion.

docs/tempo/website/grafana-agent/tail-based-sampling.md Outdated Show resolved Hide resolved
mapno and others added 2 commits July 30, 2021 12:17
Co-authored-by: achatterjee-grafana <70489351+achatterjee-grafana@users.noreply.github.com>
Co-authored-by: Koenraad Verheyden <koenraad.verheyden@posteo.net>
Copy link
Member

@kvrhdn kvrhdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good to go 👍

Copy link
Contributor

@achatterjee-grafana achatterjee-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc content looks good.

@mdisibio mdisibio merged commit 64fd2bf into grafana:main Aug 5, 2021
@mapno mapno deleted the update-docs-split-loadbalancing branch August 23, 2021 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants