Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds traceid to trace too large message #888

Merged
merged 1 commit into from
Aug 18, 2021

Conversation

mritunjaysharma394
Copy link
Contributor

@mritunjaysharma394 mritunjaysharma394 commented Aug 18, 2021

Signed-off-by: Mritunjay Sharma mritunjaysharma394@gmail.com

What this PR does:
This PR adds trace id to trace too large message
Which issue(s) this PR fixes:
Fixes #884

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@CLAassistant
Copy link

CLAassistant commented Aug 18, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the first time contribution! There are a few small changes requested.

Also, can you add a changelog entry?

modules/ingester/trace.go Outdated Show resolved Hide resolved
Signed-off-by: Mritunjay Sharma <mritunjaysharma394@gmail.com>

adds traceid to trace too large message

Signed-off-by: Mritunjay Sharma <mritunjaysharma394@gmail.com>

adds CHANGELOG

Signed-off-by: Mritunjay Sharma <mritunjaysharma394@gmail.com>
@mdisibio mdisibio merged commit eabe781 into grafana:main Aug 18, 2021
@mritunjaysharma394 mritunjaysharma394 deleted the trace-id branch August 18, 2021 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add traceid to "Trace too large" message
4 participants