Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add received and ingested bytes metrics in ingesters #979

Merged
merged 7 commits into from
Sep 24, 2021

Conversation

mapno
Copy link
Member

@mapno mapno commented Sep 22, 2021

What this PR does:

Measures received and ingested bytes in the ingesters.

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@mapno mapno force-pushed the measure-ingested-bytes branch 2 times, most recently from f967eac to b23a713 Compare September 22, 2021 15:56
@mapno mapno marked this pull request as ready for review September 22, 2021 16:14
Copy link
Member

@joe-elliott joe-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good start. I think we should:

  • remove the bytes_written and replace it with this
  • use a label on the counter to distinguish between tracedata and searchdata

CHANGELOG.md Outdated Show resolved Hide resolved
modules/ingester/instance.go Outdated Show resolved Hide resolved
@mapno mapno merged commit 9f06179 into grafana:main Sep 24, 2021
@mapno mapno deleted the measure-ingested-bytes branch September 24, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants