Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config Generation: Better names for all resources #1763

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

julienduchesne
Copy link
Member

@julienduchesne julienduchesne commented Aug 9, 2024

Follow-up to #1759: Added the resources that were missing + a safety cleanup so that all characters are allowed in the resource names

Closes #1745

Before:

resource "grafana_user" "_1" {
  email    = "admin@localhost"
  is_admin = true
  login    = "admin"
  password = "SENSITIVE_VALUE_TO_REPLACE"
}

After:

resource "grafana_user" "admin" {
  email    = "admin@localhost"
  is_admin = true
  login    = "admin"
  password = "SENSITIVE_VALUE_TO_REPLACE"
}

Follow-up to #1759
Added the resources that were missing + a safety so that all characters are allowed in the resource names
Closes #1745
@julienduchesne julienduchesne requested review from a team as code owners August 9, 2024 13:38
Copy link

github-actions bot commented Aug 9, 2024

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

@julienduchesne julienduchesne merged commit 4c854ad into main Aug 26, 2024
26 checks passed
@julienduchesne julienduchesne deleted the julienduchesne/set-preferred-names-grafana branch August 26, 2024 01:11
julienduchesne added a commit that referenced this pull request Aug 26, 2024
Tests are failing due to:
- #1764
- #1763

The `go.mod` update is needed for Go 1.23 due to grafana/pyroscope-go#118
julienduchesne added a commit that referenced this pull request Aug 27, 2024
* Fix merge conflict from two PRs
Tests are failing due to:
- #1764
- #1763

The `go.mod` update is needed for Go 1.23 due to grafana/pyroscope-go#118

* Use only alpha chars
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Better resource names in config generation
3 participants