Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ammp 0.3.0 dev9 #210

Closed
wants to merge 67 commits into from
Closed

Ammp 0.3.0 dev9 #210

wants to merge 67 commits into from

Conversation

svet-b
Copy link

@svet-b svet-b commented Jul 30, 2019

No description provided.

svet-b and others added 30 commits November 20, 2018 09:27
location information from JSON endpoint, even for table data.
The lookup key is the value from the obtained "labelField".
- locationData: “table+json(p)”
- showZoomControl
- showAttribution
- legendContainerSelector
This is a simple implementation of a panel option being used to
navigate to a new URL on click.
…a#190

Add basic variable interpolation based on keys from `dataPoint`.
Saying that, all metric values have been added to the dataPoint
beforehand by prefixing them with `point_` to allow for setting
things like `clickthroughURL: /url/to/$point_station_id` if
there’s a field called `station_id` in the current datapoint.
into clickthrough links, thus interpolating dashboard **and** dataPoint 
variables now.
This enables the interpolation of dashboard variables into each 
of the panel control settings. An example would be to have a
variable called “countrycode” which gets populated by a 
database query defined by an SQL statement like:

SELECT
  country_code AS __value,
  country_name AS __text
FROM
  stations
ORDER BY
  country_code

Then, assigning a value like that to the JSON endpoint URL panel
control setting, the machinery would interpolate the selected
value assigned to the $countrycode variable appropriately:

  jsonUrl=/api/json/stations.json?country=$countrycode
interpolation dictionary, prefixed by `request_`.

This enables to use request variables in all panel control options. 
So, when invoking the dashboard with an url query parameter like 
`map_center_latitude=42.42`, you would be able to interpolate it to 
a panel control options by i.e. assigning 
`mapCenterLatitude: $request_map_center_latitude`.
to open clickthrough target in designated window.
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 6 committers have signed the CLA.

✅ ryft
✅ dtheb
✅ leonhardhaas
✅ amotl
✅ fabienpomerol
❌ svet-b
You have signed the CLA already but the status is still pending? Let us recheck it.

@svet-b
Copy link
Author

svet-b commented Jul 30, 2019

Hmmm...meant to submit this PR against our fork. Apologies

@svet-b svet-b closed this Jul 30, 2019
@amotl
Copy link

amotl commented Jul 30, 2019

Dear @svet-b,

we will be happy to see this also as a PR against the "develop" branch at https://github.com/hiveeyes/grafana-worldmap-panel. If you don't see any intrinsic reasons against this, we would likely merge your improvements right away.

Cheers,
Andreas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants