Data: Adds support for the wide data frame format #318
Conversation
|
|
| meta: any; | ||
| } | ||
|
|
||
| export function fromWideDataFrame(data: LegacyTable[]): LegacyTimeSeries[] { |
There was a problem hiding this comment.
thought this was going to be part of toLegacyResponseData https://github.com/grafana/grafana/blob/main/packages/grafana-data/src/dataframe/processDataFrame.ts#L320 ? Having it here means this problem is still there for other panels. But I guess it's because your waiting on grafana/grafana-plugin-sdk-go#375
src/data_formatter.ts
Outdated
| export function containsWideDataFrame(data: any[]) { | ||
| if (!data || !data.length) { | ||
| return false; | ||
| } | ||
|
|
||
| return data.some((d) => d && d.hasOwnProperty('type') && d.type === 'table'); | ||
| } |
There was a problem hiding this comment.
this check seems to only check if it's a table, is this enough?
There was a problem hiding this comment.
I'm not sure but I could break this out to a separate function and add more logic like fields.length > 2 I guess?
|
This has a ton of formatting changes that are not required (or applied automatically) by the plugin settings -- can we either exclude the formatting changes, or split this into two PRs -- one for formatting and another for the wide support. I am kinda reluctant to change the supported formats here -- this plugin is super fragile anyone trying anything too complicated should use https://github.com/panodata/grafana-map-panel |
Sure, valid point. I'll revert the formatting changes. |
|
@ryantxu removed all the formatting |
|
With grafana/grafana#36737 I don't think this is still necessary |
|
Closing this in favor of grafana/grafana#36737 |
This PR is an intermediate solution for grafana/grafana#35599 until we have a better, and more generic solution in place.
Fixes #grafana/grafana#35599