Skip to content

Commit

Permalink
Remove the BaseEventEmitter from browser
Browse files Browse the repository at this point in the history
While exploring the event emitters for another PR I noticed that
although we're setting the BaseEventEmitter on browser, we're not
actually using it. This is a cleanup and as far as I can tell doesn't
affect the behaviour of the app.
  • Loading branch information
ankur22 committed Jun 15, 2023
1 parent b0c50e0 commit 4fdce45
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions common/browser.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ import (

// Ensure Browser implements the EventEmitter and Browser interfaces.
var (
_ EventEmitter = &Browser{}
_ api.Browser = &Browser{}
_ api.Browser = &Browser{}
)

const (
Expand All @@ -36,8 +35,6 @@ const (

// Browser stores a Browser context.
type Browser struct {
BaseEventEmitter

ctx context.Context
cancelFn context.CancelFunc

Expand Down Expand Up @@ -96,7 +93,6 @@ func newBrowser(
logger *log.Logger,
) *Browser {
return &Browser{
BaseEventEmitter: NewBaseEventEmitter(ctx),
ctx: ctx,
cancelFn: cancelFn,
state: int64(BrowserStateOpen),
Expand Down

0 comments on commit 4fdce45

Please sign in to comment.