-
Notifications
You must be signed in to change notification settings - Fork 41
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve null detection in parseRemoteObjectValue
Previously, we can't detect a null value: v, _ := page.GetAttribute("#el", "missing", nil) assert.Nil(t, nil, v) // v is not nil Now, `v` will be `nil` instead of "null" as a string. This enables us to detect `nil` in methods like GetAttribute, TextNode, etc. to tell the user that what they're looking for does not exist instead of returning "null" or an empty string.
- Loading branch information
1 parent
d328f6a
commit d6e3ca8
Showing
3 changed files
with
19 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters