Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter cookies by URLs #1016

Merged
merged 6 commits into from
Sep 8, 2023
Merged

Filter cookies by URLs #1016

merged 6 commits into from
Sep 8, 2023

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Aug 30, 2023 •
edited
Loading

What?

  1. Adds support for filtering cookies by URLs.
  2. Improves tests and examples.

Why?

Users can now filter cookies by URLs. See the example/cookies.js file for an example.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

Updates: #6

@inancgumus inancgumus changed the title Feat/cookie filtering Filter cookies by URLs Aug 30, 2023
@inancgumus inancgumus mentioned this pull request Aug 30, 2023
Closed
@inancgumus inancgumus self-assigned this Aug 30, 2023
@inancgumus inancgumus force-pushed the feat/cookie-filtering branch 2 times, most recently from 8c9df22 to 4a3d1d6 Compare August 30, 2023 15:49
This was referenced Aug 31, 2023
Closed
Closed
@inancgumus inancgumus added feature A new feature cookies labels Sep 7, 2023
@inancgumus inancgumus marked this pull request as ready for review September 7, 2023 12:43
ankur22
ankur22 previously approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great bit of work! Thanks for adding this feature in. Very well put together. I left some comments for you to consider.

common/browser_context.go Outdated Show resolved Hide resolved
common/browser_context.go Outdated Show resolved Hide resolved
common/browser_context.go Outdated Show resolved Hide resolved
common/browser_context.go Show resolved Hide resolved
common/browser_context.go Outdated Show resolved Hide resolved
common/browser_context_test.go Show resolved Hide resolved
common/browser_context_test.go Show resolved Hide resolved
common/browser_context_test.go Show resolved Hide resolved
common/browser_context_test.go Outdated Show resolved Hide resolved
tests/browser_context_test.go Outdated Show resolved Hide resolved
@inancgumus @ankur22
Refactor code flow, tests and errors in cookies
693a27e 
Co-authored-by: Ankur Agarwal <ankur.agarwal@grafana.com>
@inancgumus
Copy link
Member Author

Great bit of work! Thanks for adding this feature in. Very well put together. I left some comments for you to consider.

Thanks for the helpful review! 🙇 I've applied all your suggestions. cc: @ankur22

ankur22
ankur22 approved these changes Sep 8, 2023
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking into consideration the comments I made. LGTM 🙌 🚀

@inancgumus inancgumus merged commit 258b482 into main Sep 8, 2023
12 checks passed
@inancgumus inancgumus deleted the feat/cookie-filtering branch September 8, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
cookies feature A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22