Provide a consistent cookie API #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was unnecessarily setting network.Cookies to another slice.
BrowserContext.AddCookie needs the URL field to set cookies.
This is the first step in refactoring the AddCookies method. We directly accept api.Cookies instead of network.Cookies and then translating api.Cookies to network.Cookies.
We're starting to separate the CDP logic from the Goja logic.
inancgumus
force-pushed
the
refactor/add-cookie
branch
from
c37f376
to
96340b6
Compare
This change improves the browser module's security by preventing users to set internal CDP details using cookies. Fix TestBrowserContextAddCookies
This lets us ensure no dependency exists between test cases.
Incorporates the happy path test (which was already existed) into the test table and checks whether cookies are set with another field. We don't join AddCookie and Cookies tests because they test the code from different perspectives and in a more involved way for their own.
inancgumus
force-pushed
the
refactor/add-cookie
branch
from
96340b6
to
93989b8
Compare
ankur22
approved these changes
Sep 6, 2023
ankur22
reviewed
Sep 6, 2023
inancgumus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactors
BrowserContext.addCookieto[]*api.Cookieand improve its tests.Why?
Cookiesmethod.addCookiesandCookiesboth now useapi.Cookie.api.Cookietype instead of letting users set cookies by usingnetwork.Cookie(which carries CDP internal data).Checklist
Related PR(s)/Issue(s)
Updates: #6