Fix the expiration bug while adding cookies #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A cookie passed to addCookie with an expiration date doesn't work. We now take UNIX time since epoch in seconds and set the network.Cookie property before setting it on the browser side.
Also fixes a bug in the test code: tt.wantCookiesToSet, len(tt.cookies), This was comparing the cookies to set to wantCookiesToSet. But, what we want to compare with is the cookies that we get from the browser context. While testing with expired cookies, we can give three cookies, one of them should be expired and not to be found in the browser context.
inancgumus
force-pushed
the
fix/add-cookies-expiration
branch
from
f991e12
to
ba84185
Compare
ankur22
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Why?
Users should be able to set cookies with an expiration date.
Checklist
Related PR(s)/Issue(s)
Closes #1025