Fix reload & setContent to use navigation timeout

[ankur22]

What?

The following page APIs were not using the correct timeout:

page.reload()
page.setContent()

Why?

These methods should work with the default navigation instead of the default timeout to match the behaviour in Playwright.

Checklist

• I have performed a self-review of my code
• I have added tests for my changes
• I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

[inancgumus]

I've tested this with the following script, and it worked 🥳 Nice catch!

I've also checked the other methods we have by exploring the link you shared, and they all seem fine and use the correct timeout 👍

import { browser } from 'k6/x/browser';

export const options = {
  scenarios: {
    ui: {
      executor: 'per-vu-iterations',
      vus: 1,
      iterations: '1',
      options: {
        browser: {
            type: 'chromium',
        },
      },
    },
  }
};

export default async function() {
  const context = browser.newContext();
  const page = context.newPage();
  try {
    await page.goto('https://test.k6.io', { waitUntil: 'networkidle' });
    context.setDefaultNavigationTimeout(0.1); // <---
    page.reload();
  } finally {
    page.close();
  }
}

I wish we had a better error message (concise and without the first execution context changed error) when the navigation timeout happens :) Current one:

WARN[0002] failed to hide page: evaluating JS: execution context changed; most likely because of a navigation  category="Page:Close" elapsed="0 ms" source=browser
ERRO[0002] Uncaught (in promise) GoError: reloading page: timed out
        at github.com/grafana/xk6-browser/browser.mapPage.func9 (native)
        at file:///Users/inanc/grafana/k6browser/tests/pr1034.js:24:4(27)  executor=per-vu-iterations scenario=ui

The base branch was changed.

[ka3de]

LGTM.

[inancgumus]

Nice! Remember to squash as there is a fix-up commit :)