Fix fill functionality for textarea

[bandorko]

What?

Fixes a bug, where calling fill() on textarea throws error. #1225

Why?

fill() should work for any contenteditable node. Currently it works only for <input>

Checklist

• I have performed a self-review of my code
• I have added tests for my changes
• I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

#1225

[iandesj]

I would test that this works for input elements, too.

[bandorko]

@iandesj

Of course you can try it, if you build a custom k6 binary from the code on the branch. Fill() for <input> elements has worked so far, and it already has a test at https://github.com/grafana/xk6-browser/blob/main/tests/locator_test.go#L99-L105
If you find any scenario that fails with this implementation, I would be happy to deal with it.

[inancgumus]

🥳 Thanks!!

[ankur22]

LGTM 🚀

[iandesj]

Thanks @ankur22, @inancgumus, and of course @bandorko 👏🏻

What does the process look like for getting this into the next k6 release? So I know what to expect.

[ankur22]

What does the process look like for getting this into the next k6 release? So I know what to expect.

It will be in the next version of k6 (v0.50.0) which should be released in the next couple of weeks 🤞