Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async browser.newPage #1312

Merged
merged 2 commits into from
May 8, 2024
Merged

Async browser.newPage #1312

merged 2 commits into from
May 8, 2024

Conversation

inancgumus
Copy link
Member

What?

#1294

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

@inancgumus inancgumus added the async supports async (promises) label May 7, 2024
@inancgumus inancgumus self-assigned this May 7, 2024
@inancgumus inancgumus mentioned this pull request May 7, 2024
Closed
@inancgumus inancgumus marked this pull request as ready for review May 7, 2024 14:18
@inancgumus inancgumus requested a review from ankur22 May 7, 2024 14:18
ankur22
ankur22 approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/browser_context_test.go Show resolved Hide resolved
tests/browser_context_test.go Show resolved Hide resolved
tests/browser_context_test.go Show resolved Hide resolved
Base automatically changed from async/browser-closecontext to main-async May 8, 2024 10:18
@inancgumus
Async browser.newPage
a3b0093 
To run everything race-free, we run all JS code on the event loop.
@inancgumus
Update browser newPage JS examples
da14067
@inancgumus inancgumus merged commit 0e10026 into main-async May 8, 2024
14 checks passed
@inancgumus inancgumus deleted the async/browser-newpage branch May 8, 2024 10:28
inancgumus added a commit that referenced this pull request May 8, 2024
@inancgumus
Fix page goto tests for async
5cdfa61 
#1312 (comment)
@inancgumus inancgumus mentioned this pull request May 8, 2024
Merged
inancgumus added a commit that referenced this pull request May 8, 2024
@inancgumus
Fix page goto tests for async
f096a21 
#1312 (comment)
inancgumus added a commit that referenced this pull request May 9, 2024
@inancgumus
Fix page goto tests for async
3be537e 
#1312 (comment)
inancgumus added a commit that referenced this pull request May 9, 2024
@inancgumus
Fix page goto tests for async
21ed953 
#1312 (comment)
inancgumus added a commit that referenced this pull request May 29, 2024
@inancgumus
Fix page goto tests for async
27ccc97 
#1312 (comment)
inancgumus added a commit that referenced this pull request May 30, 2024
@inancgumus
Fix page goto tests for async
7aae31c 
#1312 (comment)
inancgumus added a commit that referenced this pull request Jun 7, 2024
@inancgumus
Fix page goto tests for async
51ce8b4 
#1312 (comment)
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
async supports async (promises)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22