Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn Browser panics into errors #1360

Merged
merged 3 commits into from
May 30, 2024
Merged

Turn Browser panics into errors #1360

merged 3 commits into from
May 30, 2024

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented May 30, 2024 •
edited
Loading

What?

Turns Browser panics into errors.

Why?

Stability and better error handling.

Note

I'll rebase this into main-async afterward. It makes sense to keep it in main as #1359 isn't just related to #428.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

@inancgumus inancgumus self-assigned this May 30, 2024
@inancgumus inancgumus added stability runtime stability improvements refactor labels May 30, 2024
@inancgumus inancgumus force-pushed the refactor/browser-panic-to-err branch from 66904f4 to fe2982d Compare May 30, 2024 11:25
@inancgumus inancgumus marked this pull request as ready for review May 30, 2024 11:25
@inancgumus inancgumus requested a review from ankur22 May 30, 2024 11:25
@inancgumus inancgumus changed the title Turn Browser panics to error Turn Browser panics into errors May 30, 2024
@inancgumus
Turn Browser.onAttachedToTarget panic to err
997f6fb 
We can take care of the panic in the goroutine once we decide on a
better approach later. We can't do something about it ATM.
@inancgumus
Turn Browser.UserAgent to return err
256a48c
@inancgumus
Turn Browser.Version to return err
e7e3694
@inancgumus inancgumus force-pushed the refactor/browser-panic-to-err branch from fe2982d to e7e3694 Compare May 30, 2024 12:44
@inancgumus inancgumus changed the base branch from main-async to main May 30, 2024 12:44
ankur22
ankur22 approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@inancgumus inancgumus mentioned this pull request May 30, 2024
Closed
@inancgumus inancgumus merged commit df5aade into main May 30, 2024
14 checks passed
@inancgumus inancgumus deleted the refactor/browser-panic-to-err branch May 30, 2024 13:22
@BrewTestBot BrewTestBot mentioned this pull request Jun 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

Assignees

@inancgumus inancgumus

Labels
refactor stability runtime stability improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22