Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor page.on mapping names #1478

Merged
merged 17 commits into from
Oct 11, 2024
Merged

Refactor page.on mapping names #1478

merged 17 commits into from
Oct 11, 2024

Commits on Oct 10, 2024

  1. Move pageOn mapping to a function 

    The page on mapping is large and hard to work with while making the
changes. Putting it into a new function is subjetively more readable and
makes it easier to work with the function.
    @inancgumus
    inancgumus committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    80e0a92 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary vu.VU calls from mapPageOn

    @inancgumus
    inancgumus committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7fa8233 View commit details
    Browse the repository at this point in the history

  3. Move VU runtime to variable in mapPageOn

    @inancgumus
    inancgumus committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    adeb3a6 View commit details
    Browse the repository at this point in the history

  4. Rename runInTaskQueue to mapHandler 

    No need to specify the implementation details that can change. Our main
goal here is to map the page on event handler to sobek.
    @inancgumus
    inancgumus committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ea4af1f View commit details
    Browse the repository at this point in the history

  5. Inline console API mapping closure 

    We're uniforming the events.
    @inancgumus
    inancgumus committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    49e25b3 View commit details
    Browse the repository at this point in the history

  6. Extract page on console

    @inancgumus
    inancgumus committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    ef41349 View commit details
    Browse the repository at this point in the history

  7. Extract page on metric

    @inancgumus
    inancgumus committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    00ae271 View commit details
    Browse the repository at this point in the history

  8. Refactor mapConsoleMessage to PageOnEvent 

    This is to uniform all the page on event mappers.
    @inancgumus
    inancgumus committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a800d9d View commit details
    Browse the repository at this point in the history

  9. Use cm variable in mapConsoleMessage

    @inancgumus
    inancgumus committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5c17e01 View commit details
    Browse the repository at this point in the history

  10. Refactor mapConsoleMessage out of sobek 

    No need to wrap the return values into sobek ones.
    @inancgumus
    inancgumus committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    0cd31a1 View commit details
    Browse the repository at this point in the history

  11. Refactor mapMetricevent to PageOnEvent

    @inancgumus
    inancgumus committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    9e46294 View commit details
    Browse the repository at this point in the history

  12. Remove excessive VU call mapMetricEvent

    @inancgumus
    inancgumus committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    0e8566b View commit details
    Browse the repository at this point in the history

  13. Use em variable in mapMetricEvent

    @inancgumus
    inancgumus committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    755208e View commit details
    Browse the repository at this point in the history

  14. Extract err from mapMetricEvent call

    @inancgumus
    inancgumus committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    586bdef View commit details
    Browse the repository at this point in the history

  15. Rename channel c to done

    @inancgumus
    inancgumus committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f1a589f View commit details
    Browse the repository at this point in the history

  16. Rename event to eventName

    @inancgumus
    inancgumus committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    c95ba38 View commit details
    Browse the repository at this point in the history

  17. Rename mapPageOn handler to handleEvent

    @inancgumus
    inancgumus committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    110effe View commit details
    Browse the repository at this point in the history