This repository has been archived by the owner on Jan 30, 2025. It is now read-only.
Add method field on Match object for page.on('metric')
#1490
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This change adds a new field to the
Match
object inpage.on('metric')
. It allows the user to add the request method to it so that the tagging can be fine tuned to group requests with the same url and method.method
is an optional field, and if it's not defined then the grouping will be done for all urls that match regardless of the request method.Why?
The use case for this is when requests are made against the same URL but with different request methods. A simple example is a
PUT
to/cart/123
to add an item to the cart, and aGET
to/cart/123
to retrieve the cart.Checklist
Related PR(s)/Issue(s)
Updates: #1450