This repository has been archived by the owner on Jan 30, 2025. It is now read-only.
Fix frame.title #1538
Merged
Fix frame.title #1538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fixes involves casting the value from evaluate to a string, and if that doesn't cast to a string we should return an error. The case was missing from the earlier implementation.
ankur22
requested review from
inancgumus and
joanlopez
and removed request for
a team
inancgumus
approved these changes
Nov 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
The fixes involves casting the value from evaluate to a string, and if that doesn't cast to a string we should return an error. The cast was missing from the earlier implementation.
Why?
Calling
frame.titlecauses an error since the value returned from evaluate is aninterface{}and not a string.Checklist
Related PR(s)/Issue(s)
#1539