Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

Fix onLoadingFinished reqFromParent nil check #579

Merged
merged 1 commit into from
Oct 11, 2022
Merged

Fix onLoadingFinished reqFromParent nil check #579

merged 1 commit into from
Oct 11, 2022

Conversation

mstoykov
Copy link
Contributor

Updates #542

@mstoykov mstoykov added this to the v0.6.0 milestone Oct 11, 2022
@mstoykov mstoykov mentioned this pull request Oct 11, 2022
Closed
inancgumus
inancgumus approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@inancgumus inancgumus added the bug Something isn't working label Oct 11, 2022
@inancgumus inancgumus changed the title Fix what seems like an obvious logical error Fix onLoadingFinished reqFromParent nil check Oct 11, 2022
@mstoykov mstoykov merged commit 1114144 into main Oct 11, 2022
@mstoykov mstoykov deleted the onLoadingFinishedFix branch October 11, 2022 08:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@inancgumus inancgumus inancgumus approved these changes

@imiric imiric Awaiting requested review from imiric

@ankur22 ankur22 Awaiting requested review from ankur22

Assignees

@mstoykov mstoykov

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mstoykov @inancgumus