Add assert log contains and log dump helpers #802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
force-pushed
the
add/687-assert-log-contains
branch
2 times, most recently
from
65fec61
to
da43ace
Compare
This helps us to better see the log output locally and on CI if the test fails.
inancgumus
force-pushed
the
add/687-assert-log-contains
branch
from
da43ace
to
7bd8275
Compare
inancgumus
changed the title
ankur22
approved these changes
Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These helpers should help us to better see the log output locally and on CI if the test fails. I constantly needed to dump log requests when testing #687. This helper automatically does that for us.
For example, if the following fails, we have no idea why it fails unless we dump the logs by hand:
xk6-browser/tests/network_manager_test.go
Line 26 in 3482792
Example output when we use the
assertContainshelper:xk6-browser/tests/network_manager_test.go
Line 26 in 7bd8275
=== RUN TestURLSkipRequest === PAUSE TestURLSkipRequest === CONT TestURLSkipRequest network_manager_test.go:26: expected log cache to contain "skipping request handling of data URL", but it didn't. network_manager_test.go:26: -------------------------------------------------------------------------------- network_manager_test.go:26: wsURL:"ws://127.0.0.1:57218/devtools/browser/6e48a690-4676-4b99-9efe-8223a3d91cda" ... network_manager_test.go:26: sid:71D7211C20290E9E84D3E61C20BA2C6E tid:F077AC9457875E49FE074C9D8F7F1619 method:"Page.enable" network_manager_test.go:26: sid:71D7211C20290E9E84D3E61C20BA2C6E tid:F077AC9457875E49FE074C9D8F7F1619 network_manager_test.go:26: sid:71D7211C20290E9E84D3E61C20BA2C6E tid:F077AC9457875E49FE074C9D8F7F1619 method:"Page.enable" network_manager_test.go:26: SUPPOSED TO BE HERE! network_manager_test.go:26: sid:71D7211C20290E9E84D3E61C20BA2C6E tid:F077AC9457875E49FE074C9D8F7F1619 method:"Page.getFrameTree" ...