Rename web vital metrics #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're renaming them from webvital_xxx_xxx_xxx to browser_web_vital_xxx. This change benefits us in three ways: 1. Browser metrics will be namespaced with browser_ 2. webvital is two words, so web vital 3. We're assuming that users will have the context of web vital metrics so that we can use the abbreviations which also helps with the display of them at the end of the test run. Closes: #884
ankur22
force-pushed
the
rename/884-rename-web-vitals
branch
from
b740373
to
669dd75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
We're renaming them from
webvital_xxx_xxx_xxxtobrowser_web_vital_xxx. This change benefits us in three ways:browser_;Closes: #884
Checklist
Tasks
Optional tasks
Tasks