Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsanitize instance scenario data #917

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Unsanitize instance scenario data #917

merged 1 commit into from
Jun 1, 2023

Conversation

inancgumus
Copy link
Member

This is needed because we receive the remote's sanitized (quoted) scenario JSON data.

Related: #906 and #888.

@inancgumus
Add unquoting to the received scenario data
0b425b1 
This is needed because we're receiving a sanitized (quoted) sceneario
JSON data from remote.

Related: #906 and #888.
@inancgumus inancgumus self-assigned this Jun 1, 2023
@inancgumus inancgumus requested review from ankur22 and ka3de June 1, 2023 11:16
ankur22
ankur22 approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@inancgumus inancgumus merged commit 9c23aba into main Jun 1, 2023
@inancgumus inancgumus deleted the fix/906-parse-instance-scenario-data branch June 1, 2023 12:28
@inancgumus inancgumus added the bug Something isn't working label Jun 1, 2023
@inancgumus inancgumus added this to the v0.10.0 milestone Jun 1, 2023
@inancgumus inancgumus changed the title Add unquoting to the received scenario data Unsanitize instance scenario data Jun 1, 2023
@inancgumus inancgumus added the remote remote browser related label Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

@ka3de ka3de Awaiting requested review from ka3de

Assignees

@inancgumus inancgumus

Labels
bug Something isn't working remote remote browser related
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@inancgumus @ankur22