Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golangci to renovate configuration #239

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Conversation

nadiamoe
Copy link
Member

@nadiamoe nadiamoe commented Jun 28, 2023

Description

This PR instructs renovate to check golangci-lint tag from the comment in .golangci.yml.

Demo PR: https://github.com/roobre/xk6-disruptor/pull/14

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make test) and all tests pass.
  • I have run relevant e2e test locally (make e2e-xxx for agent, disruptors, kubernetes or cluster related changes)
  • Any dependent changes have been merged and published in downstream modules

@nadiamoe nadiamoe requested a review from pablochacin June 28, 2023 09:34
@pablochacin pablochacin changed the title renovate: bump golangci version Add golangci to renovate configuration Jun 28, 2023
@pablochacin
Copy link
Collaborator

@roobre I don't think this PR fixes #232 because we still need to either change the configuration of golangci or make changes in the code to solve the issues listed by the linter as seen in roobre#14

@nadiamoe
Copy link
Member Author

You're right, I was too optimistic thinking we would be able to merge the update just fine. Let me strip the Fixes line.

Copy link
Collaborator

@pablochacin pablochacin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nadiamoe nadiamoe merged commit 2aaebf5 into main Jun 30, 2023
@nadiamoe nadiamoe deleted the renovate-golangci-yml branch June 30, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants